Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Feb 18, 2019

I believe everything is good to go. I'm not sure on 2 things:
1. How to check my code coverage report.
2. I need help with the proper commit message format.

Please let me know if you need anything from me at this point.

Thank you for your time! This has been a great exercise for me!

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #254   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          95     95           
  Lines         465    465           
=====================================
  Hits          465    465

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ee1a3...8a61c06. Read the comment docs.

@bolah2009
Copy link
Contributor

Hi @linzmeyer. Well-done 👍.
I think everything is looking good. The codecov report is in charge of the code coverage and I think it's good to go 👍
For commit message, since you adding new feature you could use a format like this: feat(flip-bool): add 'flip-bool' function

For more details check out https://github.com/conventional-changelog-archived-repos/conventional-changelog-angular/blob/master/convention.md

@kentcdodds
Copy link
Member

Thanks @bolah2009. @linzmeyer, would you like to add tests for your new function as well as include it in the exports in src/index.js?

@ghost ghost closed this by deleting the head repository Feb 3, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants